Introduce devcontainers configuration#564
Merged
gmargaritis merged 16 commits intopython:3.12from Feb 20, 2025
Merged
Conversation
gmargaritis
force-pushed
the
introduce-devcontainers-config
branch
from
d9ba86e to
e9a0e1e
Compare
Collaborator
Author
|
Removed |
lysnikolaou
reviewed
Nov 28, 2024
Member
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
The devcontainer config looks good. Left a couple comments on the Makefile changes and the contributing guide.
Collaborator
|
@gmargaritis πολύ καλή δουλειά, και πιστεύω ότι είναι κάτι που θα εξυπηρετήσει. Εγώ προσωπικά, δεν έχω κάτι να προσθέσω μου φαίνεται μια χαρά, και είναι πολύ καλό που έχουμε 2 τρόπους σεταρίσματος του έργου. |
skpanagiotis
reviewed
Dec 4, 2024
Collaborator
skpanagiotis
left a comment
skpanagiotis
left a comment
There was a problem hiding this comment.
Πιστεύω ότι μπορεί να ενσωματωθεί ως τρόπος.
* Translated distributing/index.po * Update index.po * Update index.po * [pre-commit.ci lite] apply automatic fixes --------- Co-authored-by: = <=> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: skpanagiotis <panagiotis.skias@gmail.com>
Collaborator
Author
|
@lysnikolaou Can you do a double check and approve this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added devcontainers support
Added the following make commands
make http-serve: serve the translation preview on a webservermake preview: builds and serves the translation preview by openingindex.htmlon the user's browsermake http-preview: builds and serves the translation preview a webservermake lint: runspowrapandcheck_spellcheck.pyon all.pofiles@pygreece/translation I'd vouch to only keep the
http-previewcommand for serving the translation preview.